Merge pull request #85 from nemesis/remove_deprecated_parameters

Remove from_made_on and to_made_on from transaction due to deprecation
saltedge · Oct 31, 2017 · 21205c8 · 21205c8
2 parents a6e60fb + 425042b
commit 21205c8
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 16 deletions.
diff --git a/Classes/API/SEAPIRequestManager.h b/Classes/API/SEAPIRequestManager.h
@@ -239,9 +239,7 @@ typedef NS_ENUM(NSUInteger, SEAPIRequestManagerSSLPinningMode) {
  @code
  // parameters example, all optional
  {
-    "from_id": 1839,
-    "from_made_on": [NSDate dateWithTimeIntervalSinceReferenceDate:0],
-    "to_made_on": [NSDate date]
+    "from_id": 1839
  }
  @endcode
 
@@ -284,9 +282,7 @@ typedef NS_ENUM(NSUInteger, SEAPIRequestManagerSSLPinningMode) {
  @code
  // parameters example, all optional
  {
-    "from_id": 2370,
-    "from_made_on": [NSDate date],
-    "to_made_on": [NSDate dateWithTimeIntervalSinceNow:oneDayInterval]
+    "from_id": 2370
  }
  @endcode
 

diff --git a/Classes/API/SEAPIRequestManager.m b/Classes/API/SEAPIRequestManager.m
@@ -673,14 +673,6 @@ - (void)requestTransactionsListWithPath:(NSString*)transactionsPath
     NSMutableDictionary* finalParameters = parameters ? parameters.mutableCopy : [NSMutableDictionary dictionary];
     finalParameters[kAccountIdKey] = accountId;
 
-    if (finalParameters[kFromMadeOnKey]) {
-        finalParameters[kFromMadeOnKey] = [DateUtils YMDStringFromDate:finalParameters[kFromMadeOnKey]];
-    }
-
-    if (finalParameters[kToMadeOnKey]) {
-        finalParameters[kToMadeOnKey] = [DateUtils YMDStringFromDate:finalParameters[kToMadeOnKey]];
-    }
-
     [self requestPaginatedResourceWithPath:transactionsPath
                                  container:@[].mutableCopy
                                    headers:[self sessionHeadersWithLoginSecret:loginSecret]

diff --git a/Classes/Utils/Constants.h b/Classes/Utils/Constants.h
@@ -66,8 +66,6 @@ static NSString* const kReturnToKey              = @"return_to";
 static NSString* const kRedirectURLKey           = @"redirect_url";
 static NSString* const kCustomerSecretKey        = @"secret";
 static NSString* const kAccountIdKey             = @"account_id";
-static NSString* const kFromMadeOnKey            = @"from_made_on";
-static NSString* const kToMadeOnKey              = @"to_made_on";
 static NSString* const kMobileKey                = @"mobile";
 static NSString* const kIdentifierKey            = @"identifier";
 static NSString* const kLoginStageFinish         = @"finish";

diff --git a/Salt Edge API Demo.xcodeproj/project.pbxproj b/Salt Edge API Demo.xcodeproj/project.pbxproj
@@ -861,6 +861,7 @@
 					"$(inherited)",
 				);
 				INFOPLIST_FILE = "Salt Edge API DemoTests/Salt Edge API DemoTests-Info.plist";
+				IPHONEOS_DEPLOYMENT_TARGET = 8.0;
 				PRODUCT_BUNDLE_IDENTIFIER = "com.saltedge.${PRODUCT_NAME:rfc1034identifier}";
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				TEST_HOST = "$(BUNDLE_LOADER)";
@@ -880,6 +881,7 @@
 				GCC_PRECOMPILE_PREFIX_HEADER = YES;
 				GCC_PREFIX_HEADER = "Salt Edge API Demo/Salt Edge API Demo-Prefix.pch";
 				INFOPLIST_FILE = "Salt Edge API DemoTests/Salt Edge API DemoTests-Info.plist";
+				IPHONEOS_DEPLOYMENT_TARGET = 8.0;
 				PRODUCT_BUNDLE_IDENTIFIER = "com.saltedge.${PRODUCT_NAME:rfc1034identifier}";
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				TEST_HOST = "$(BUNDLE_LOADER)";