Set default DNS domain for gateway #20
Conversation
| @@ -91,6 +91,9 @@ dhcp_lease_duration = 600 | |||
|
|
|||
| # Domain to use for building the hostnames (string value) | |||
| #dns_domain = openstacklocal | |||
| {% if neutron.get('dns_domain') %} | |||
There was a problem hiding this comment.
provide default False
why it's this neutron.dns_domain and not neutron.gateway.dns_domain
also update mitaka conf if relevant.
There was a problem hiding this comment.
Done. Pushing a update shortly.
There was a problem hiding this comment.
It is neutron.dns_domain because neutron is neutron.gateway from the map.jinja in the context of this template: https://github.com/salt-formulas/salt-formula-neutron/blob/master/neutron/files/ocata/neutron-generic.conf.Debian#L2
| @@ -6,6 +6,7 @@ parameters: | |||
| neutron: | |||
| gateway: | |||
| enabled: true | |||
| dns_domain: novalocal | |||
There was a problem hiding this comment.
This is the fix to the bug I reported though. Removing this line the bug would still exist in default deployments
If you want to remove the default here, then you probably should also remove the default in nova
https://github.com/salt-formulas/salt-formula-nova/blob/master/metadata/service/control/single.yml#L16 ,
https://github.com/salt-formulas/salt-formula-nova/blob/master/metadata/service/control/container.yml#L18 ,
and
https://github.com/salt-formulas/salt-formula-nova/blob/master/metadata/service/control/cluster.yml#L16
Would you rather fix the defaults in that package?
There was a problem hiding this comment.
Also in this package:
https://github.com/salt-formulas/salt-formula-neutron/blob/master/metadata/service/control/single.yml#L13
https://github.com/salt-formulas/salt-formula-neutron/blob/master/metadata/service/control/container.yml#L14
https://github.com/salt-formulas/salt-formula-neutron/blob/master/metadata/service/control/cluster.yml#L11
Would you like me to remove those defaults as well to make it consistent?
Make the gateway consistent with the controller. Addresses Issue salt-formulas#19
tgerdes
force-pushed
the
default_dns_domain
branch
from
75987e4 to
57de03c
Compare
Make the gateway consistent with the controller.
Addresses #19