Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jschonning/w 14245254 #205

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Jschonning/w 14245254 #205

wants to merge 9 commits into from

Conversation

jschonning-sf
Copy link
Collaborator

@jschonning-sf jschonning-sf commented Nov 3, 2023

What does this PR do?

Adding a new flag, --allversions. This will migrate all versions of a component (omniscript, integration procedure and flex card).

@W-14245254@
@W-14245279@

@jschonning-sf jschonning-sf requested a review from a team as a code owner November 3, 2023 19:47
Copy link

salesforce-cla bot commented Nov 3, 2023

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Johan Schonning <j***@j***.i***.s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated.

@jschonning-sf jschonning-sf added enhancement New feature or request and removed cla:missing labels Nov 3, 2023
@agarcia-sf
Copy link
Collaborator

@jschonning-sf , I am not sure if this should be done as there is a catch here.

Once you insert a new OmniScript, the save hooks will calculate the new version so, if you have version 2, 3, 4 on the source, the target will be 1, 2, 3. While this might be good to have a consistent versioning, you need to let the customer know that there was a change of version that might not match. Also, the query needs to be modified to be sort by type, subtype, language, version.

@agarcia-sf
Copy link
Collaborator

@jschonning-sf , I am not sure if this should be done as there is a catch here.

Once you insert a new OmniScript, the save hooks will calculate the new version so, if you have version 2, 3, 4 on the source, the target will be 1, 2, 3. While this might be good to have a consistent versioning, you need to let the customer know that there was a change of version that might not match. Also, the query needs to be modified to be sort by type, subtype, language, version.

cc. @twu-sf

@jschonning-sf
Copy link
Collaborator Author

jschonning-sf commented Nov 3, 2023

@jschonning-sf , I am not sure if this should be done as there is a catch here.
Once you insert a new OmniScript, the save hooks will calculate the new version so, if you have version 2, 3, 4 on the source, the target will be 1, 2, 3. While this might be good to have a consistent versioning, you need to let the customer know that there was a change of version that might not match. Also, the query needs to be modified to be sort by type, subtype, language, version.

cc. @twu-sf

So it seems that I can add the same version as the source have in the target. I could sort on version just to make it more bullet proof though. That way version 1->1 would happen automatically.

This will set the version of the source in the target.

mappedOsName = mappedOmniScript[OmniScriptMappings.Type__c] + '_' + mappedOmniScript[OmniScriptMappings.SubType__c] + (mappedOmniScript[OmniScriptMappings.Language__c] ? '_' + mappedOmniScript[OmniScriptMappings.Language__c] : '') + '_' + mappedOmniScript[OmniScriptMappings.Version__c];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:missing enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants