chore: avoid nodejs modules #487
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colincasey
reviewed
Jan 9, 2025
| @@ -2,7 +2,9 @@ | |||
|
|
|||
| import eslint from '@eslint/js' | |||
| import prettierRecommended from 'eslint-plugin-prettier/recommended' | |||
| // eslint-disable-next-line import/no-unresolved | |||
There was a problem hiding this comment.
I think this is due to import-js/eslint-plugin-import#1485 which includes a fix that works for me (locally) but produces a couple extra warnings.
colincasey
reviewed
Jan 9, 2025
| @@ -11,6 +13,9 @@ export default tseslint.config( | |||
| }, | |||
| eslint.configs.recommended, | |||
| ...tseslint.configs.strictTypeChecked, | |||
| pluginImport.recommended, | |||
| // @ts-expect-error not sure why the plugin isn't type correctly, but it works... | |||
There was a problem hiding this comment.
I removed this after including the fix mentioned above and did not see any errors.
|
Nice! This was the plugin I was looking at last night when trying to figure out how we can best avoid breaking non-Node runtimes. |
Scutua
previously approved these changes
Jan 15, 2025
colincasey
dismissed
Scutua’s stale review
Only maintainers should be approving PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new eslint plugin to avoid node's built in modules, and hopefully help keep our package more cross-platform compatible.