Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Refactoring JARM into a library and a command-line tool #2

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

botherder
Copy link

@botherder botherder commented Nov 18, 2020

Firstly, thanks for the work you've put into devising this fingerprinting technique and providing a usable open-source tool.

This is still a work in progress, and I am aware it is a rather substantial refactor, but I wanted to initiate this conversation early, to better guide the next steps on this.

I have forked this repository and started refactoring the codebase in order to turn JARM in both a Python library and a command-line tool. I think it could make JARM more easily accessible and beneficial to diverse use cases. I have also created a skeleton of a setuptools install script, so this would also be ready for distribution over PyPi.

With these changes, JARM can now be invoked as library simply like following:

from jarm import JARM
j = JARM("salesforce.com", 443)
j.run()
print(j.raw)
print(j.hash)

There is also a command-line utility in bin/, which leverages the library as above. It can be installed through python3 setup.py install or can be invoked with python3 bin/jarm. The functionality is more or less the same as your script, although I have changed it to print results in CSV and JSON format in stdout for Unix-style processing, rather than saving to file.

Let me know what you think and whether there would be any interest in merging.

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @botherder to sign the Salesforce.com Contributor License Agreement.

@zmallen
Copy link

zmallen commented Nov 24, 2020

Id like to use this as a library as well! Glad to see someone taking the effort to contribute

@utoni
Copy link

utoni commented Apr 15, 2021

Any progress here? I would really like to see this PR in the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants