-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Update field logic #394
Open
mpuyosa91
wants to merge
2
commits into
salesagility:hotfix
Choose a base branch
from
mpuyosa91:feature/update_field_logic
base: hotfix
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature Update field logic #394
mpuyosa91
wants to merge
2
commits into
salesagility:hotfix
from
mpuyosa91:feature/update_field_logic
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
mpuyosa91
force-pushed
the
feature/update_field_logic
branch
from
November 16, 2023 13:43
ba2a9c1
to
1551c8b
Compare
Hi @mpuyosa91 could you add the PR or the issue number to the PR please? |
Hi @mpuyosa91, as we spoke this code should be replacing the |
clemente-raposo
added
Status:Requires Updates
Issues & PRs which requires input or update from the author
Status: Requires Code Review
labels
Dec 6, 2023
mpuyosa91
added
Status: Fix Proposed
A issue that has a PR related to it that provides a possible resolution
and removed
Status:Requires Updates
Issues & PRs which requires input or update from the author
labels
Dec 6, 2023
mpuyosa91
changed the title
Feature Update field logic
Closes #394 Feature Update field logic
Dec 6, 2023
core/app/core/src/lib/fields/field-logic/field-logic.manager.ts
Outdated
Show resolved
Hide resolved
mpuyosa91
force-pushed
the
feature/update_field_logic
branch
from
December 6, 2023 13:15
56565e5
to
fa9ebb9
Compare
mpuyosa91
changed the title
Closes #394 Feature Update field logic
Feature Update field logic
Dec 6, 2023
clemente-raposo
added
Status:Requires Updates
Issues & PRs which requires input or update from the author
and removed
Status: Fix Proposed
A issue that has a PR related to it that provides a possible resolution
labels
Dec 7, 2023
mpuyosa91
force-pushed
the
feature/update_field_logic
branch
from
December 8, 2023 11:10
fa9ebb9
to
96ad41e
Compare
mpuyosa91
added
Status: Fix Proposed
A issue that has a PR related to it that provides a possible resolution
and removed
Status:Requires Updates
Issues & PRs which requires input or update from the author
labels
Dec 8, 2023
core/app/core/src/lib/fields/field-logic/field-logic.manager.ts
Outdated
Show resolved
Hide resolved
core/app/core/src/lib/fields/field-logic/update-field/update-field.action.ts
Outdated
Show resolved
Hide resolved
clemente-raposo
added
Status:Requires Updates
Issues & PRs which requires input or update from the author
and removed
Status: Fix Proposed
A issue that has a PR related to it that provides a possible resolution
labels
Dec 14, 2023
mpuyosa91
force-pushed
the
feature/update_field_logic
branch
from
January 5, 2024 13:41
96ad41e
to
50b0b1b
Compare
mpuyosa91
added
Status: Fix Proposed
A issue that has a PR related to it that provides a possible resolution
and removed
Status:Requires Updates
Issues & PRs which requires input or update from the author
labels
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Status: Fix Proposed
A issue that has a PR related to it that provides a possible resolution
Status: Requires Code Review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a feature that consists of being able to modify a field due to certain logic.
Description
core/app/core/src/lib/fields/field-logic/actionable-field-logic/actionable-field-logic.action.ts
Abstract class ActionableFieldLogicActionHandler that can hold general and reusable functions across field logic actions.core/app/core/src/lib/fields/field-logic/update-field/update-field.action.ts
Actual UpdateFieldAction class that holds the logic.core/app/core/src/lib/fields/field-logic/field-logic.manager.ts:[40, 66, 78]
Registration of the UpdateFieldAction as Field Logic Action.core/app/core/src/lib/services/logic/active-logic-checker.service.ts
: Creation of ActiveLogicChecker class that holds the routine for checking if a logic is active or not.core/app/core/src/lib/core.ts:364
Export created classesMotivation and Context
This was needed by a client.
How To Test This
SUBJECT
fieldMODIFY SUBJECT
toCustom
orClear
.Custom
, Subject field will change toCustom Case Subject
.Clear
, Subject field will be cleared.Test Environment
public/legacy/custom/Extension/modules/Cases/Ext/Vardefs/modify_subject.php
public/legacy/custom/Extension/modules/Cases/Ext/Language/en_us.modify_subject.php
public/legacy/custom/Extension/application/Ext/Language/en_us.Cases.php
public/legacy/custom/modules/Cases/metadata/detailviewdefs.php
public/legacy/custom/modules/Cases/metadata/editviewdefs.php
public/legacy/custom/Extension/modules/Cases/Ext/Vardefs/_override_name.php
Types of changes
Final checklist