Add logs when we found isFee from Avalara response
#1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9b0e801 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
lkostrowski
reviewed
Oct 28, 2024
| const hasFee = shippingLine.details?.some((details) => details.isFee); | ||
|
|
||
| if (hasFee) { | ||
| logger.warn("Shipping line has a fee. App will report this fee as shipping_tax_rate", { |
There was a problem hiding this comment.
I'm open to change but we are wrongly reporting rate to Saleor - maybe for Colorado Tax it will be fine (as this is different product - at least if client uses our recommended integration guide) but for other cases we may not be lucky 🤔
There was a problem hiding this comment.
If this is wrong, maybe this should be error?
vercel
bot
temporarily deployed
to
Preview – saleor-app-products-feed
lkostrowski
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of the PR
Added warning logs when Avalara returns
isFeein product or shipping line details.Related issues
Checklist