Add LoggerVercelTransport and use it in AvaTax app
#1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
🦋 Changeset detectedLatest commit: dc4f0c7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
krzysztofzuraw
added
the
skip changeset
vercel
bot
temporarily deployed
to
Preview – saleor-app-products-feed
vercel
bot
temporarily deployed
to
Preview – saleor-app-products-feed
krzysztofzuraw
removed
the
skip changeset
krzysztofzuraw
changed the title
LoggerVercelTransport and use it in AvaTax app
poulch
approved these changes
Oct 14, 2024
lkostrowski
approved these changes
Oct 14, 2024
Comment on lines
-84
to
-90
| address: JSON.stringify({ | ||
| address: { | ||
| city: "test", | ||
| country: "test", | ||
| zip: "10111", | ||
| state: "NY", | ||
| street: "test", | ||
| }), |
There was a problem hiding this comment.
interesting that it works but technically js doesn't preserve keys order (or guarantees it), so it may be flaky - one day stringified object can be different
but non blocking, if it works, we dont have to touch it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of the PR
Related issues
Checklist