Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dockerfile for avatax app dev mode #1353

Merged
merged 5 commits into from
May 22, 2024
Merged

Add Dockerfile for avatax app dev mode #1353

merged 5 commits into from
May 22, 2024

Conversation

krzysztofzuraw
Copy link
Member

@krzysztofzuraw krzysztofzuraw commented May 17, 2024 •
edited
Loading

Scope of the PR

This PR adds dev dockerfile so developers can run avatax app without installing all JS tooling.

Related issues

Checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 17, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 36ff319

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented May 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saleor-app-avatax ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 7:28am
saleor-app-smtp ✅ Ready (Inspect) Visit Preview May 22, 2024 7:28am
10 Ignored Deployments
Name Status Preview Comments Updated (UTC)
saleor-app-cms ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 7:28am
saleor-app-crm ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 7:28am
saleor-app-data-importer ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 7:28am
saleor-app-emails-and-messages ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 7:28am
saleor-app-invoices ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 7:28am
saleor-app-klaviyo ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 7:28am
saleor-app-products-feed ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 7:28am
saleor-app-search ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 7:28am
saleor-app-segment ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 7:28am
saleor-app-slack ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 7:28am

@krzysztofzuraw krzysztofzuraw changed the title use docker Add Dockerfile for avatax app dev mode May 17, 2024
@krzysztofzuraw krzysztofzuraw added the skip changeset Attach this label to PRs which does not need changes description for the release notes. label May 17, 2024
@krzysztofzuraw krzysztofzuraw marked this pull request as ready for review May 17, 2024 09:08
@krzysztofzuraw krzysztofzuraw requested review from a team as code owners May 17, 2024 09:08
lkostrowski
lkostrowski reviewed May 17, 2024
View reviewed changes
Dockerfile.dev Outdated Show resolved Hide resolved
@lkostrowski lkostrowski requested a review from NyanKiyoshi May 17, 2024 09:13
witoszekdev
witoszekdev previously approved these changes May 17, 2024
View reviewed changes
Dockerfile.dev Show resolved Hide resolved
@krzysztofzuraw krzysztofzuraw merged commit 43e396a into main May 22, 2024
23 checks passed
@krzysztofzuraw krzysztofzuraw deleted the use-docker branch May 22, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkostrowski lkostrowski lkostrowski approved these changes

@NyanKiyoshi NyanKiyoshi Awaiting requested review from NyanKiyoshi

@witoszekdev witoszekdev Awaiting requested review from witoszekdev

Assignees

@krzysztofzuraw krzysztofzuraw

Labels
App: AvaTax skip changeset Attach this label to PRs which does not need changes description for the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krzysztofzuraw @witoszekdev @lkostrowski