Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMTP App: Tests for main business useCase #1347

Merged
merged 11 commits into from
May 20, 2024
Merged

Conversation

lkostrowski
Copy link
Member

@lkostrowski lkostrowski commented May 14, 2024

Scope of the PR

todo

  • finish tests for successful response

  • convert errors from useCase to response status codes

Related issues

Checklist

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saleor-app-avatax ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 5:59pm
saleor-app-cms ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 5:59pm
saleor-app-crm ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 5:59pm
saleor-app-data-importer ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 5:59pm
saleor-app-emails-and-messages ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 5:59pm
saleor-app-invoices ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 5:59pm
saleor-app-klaviyo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 5:59pm
saleor-app-products-feed ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 5:59pm
saleor-app-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 5:59pm
saleor-app-segment ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 5:59pm
saleor-app-slack ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 5:59pm
saleor-app-smtp ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 5:59pm

Copy link

changeset-bot bot commented May 14, 2024

⚠️ No Changeset found

Latest commit: b5f797a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lkostrowski lkostrowski force-pushed the SHOPX-686-use-case branch from dae6190 to 9363d9d Compare May 15, 2024 14:51
@lkostrowski lkostrowski force-pushed the SHOPX-686-use-case branch from 9363d9d to ce64d3e Compare May 17, 2024 12:08
@lkostrowski lkostrowski dismissed stale reviews from witoszekdev and krzysztofzuraw via b5f797a May 20, 2024 17:47
@lkostrowski lkostrowski force-pushed the SHOPX-686-use-case branch from 7eca740 to b5f797a Compare May 20, 2024 17:47
@lkostrowski lkostrowski requested a review from a team as a code owner May 20, 2024 17:47
@lkostrowski lkostrowski merged commit de70c10 into main May 20, 2024
23 checks passed
@lkostrowski lkostrowski deleted the SHOPX-686-use-case branch May 20, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App: SMTP skip changeset Attach this label to PRs which does not need changes description for the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants