Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chunk of refactors and error handling #1345

Merged
merged 14 commits into from
May 14, 2024
Merged

Chunk of refactors and error handling #1345

merged 14 commits into from
May 14, 2024

Conversation

lkostrowski
Copy link
Member

Scope of the PR

  1. Refactor services
  2. Implement error handling
  3. Bunch of tests

Next steps:

  1. PR with Tests for use-case (main business component)
  2. PR with logger overhaul

Related issues

Checklist

@lkostrowski lkostrowski requested a review from a team as a code owner May 13, 2024 19:46
Copy link

changeset-bot bot commented May 13, 2024

⚠️ No Changeset found

Latest commit: f17a2cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saleor-app-avatax 🛑 Canceled (Inspect) May 13, 2024 7:59pm
saleor-app-cms 🛑 Canceled (Inspect) May 13, 2024 7:59pm
saleor-app-crm ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 7:59pm
saleor-app-data-importer ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 7:59pm
saleor-app-emails-and-messages ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 7:59pm
saleor-app-invoices ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 7:59pm
saleor-app-klaviyo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 7:59pm
saleor-app-products-feed ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 7:59pm
saleor-app-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 7:59pm
saleor-app-segment 🛑 Canceled (Inspect) May 13, 2024 7:59pm
saleor-app-slack 🛑 Canceled (Inspect) May 13, 2024 7:59pm
saleor-app-smtp 🛑 Canceled (Inspect) 💬 Add feedback May 13, 2024 7:59pm

@lkostrowski lkostrowski merged commit 95fb29a into main May 14, 2024
24 of 25 checks passed
@lkostrowski lkostrowski deleted the SHOPX-686 branch May 14, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Attach this label to PRs which does not need changes description for the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants