Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use type instead enums in codegen types #1306

Merged
merged 1 commit into from
Apr 15, 2024
Merged

use type instead enums in codegen types #1306

merged 1 commit into from
Apr 15, 2024

Conversation

lkostrowski
Copy link
Member

@lkostrowski lkostrowski commented Apr 7, 2024 •
edited
Loading

Scope of the PR

Before:
CleanShot 2024-04-07 at 18 55 46@2x

After
CleanShot 2024-04-07 at 18 54 48@2x

when researching found that we should update graphql-codegen

  1. https://the-guild.dev/graphql/codegen/plugins/typescript/typed-document-node this should not be used directly
  2. https://the-guild.dev/graphql/codegen/plugins/typescript/typescript-document-nodes this can be configured to use JSON instead gql which may be smaller in bundle size (gql has a lot of whitespace) → need to be checked
  3. using client-preset is recommended so we should migrate

Related issues

Checklist

@vercel Vercel
Copy link

vercel bot commented Apr 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apps-slack ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 7:35am
apps-slack-otu2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 7:35am
saleor-app-avatax ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 7:35am
saleor-app-cms ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 7:35am
saleor-app-crm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 7:35am
saleor-app-data-importer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 7:35am
saleor-app-emails-and-messages ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 7:35am
saleor-app-invoices ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 7:35am
saleor-app-klaviyo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 7:35am
saleor-app-products-feed ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 7:35am
saleor-app-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 7:35am
saleor-app-segment ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 7:35am
saleor-app-slack ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 7:35am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9b6cb27

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lkostrowski lkostrowski added the skip changeset Attach this label to PRs which does not need changes description for the release notes. label Apr 7, 2024
@lkostrowski lkostrowski force-pushed the codegen-enums-to-types branch from 1bdb283 to 9b6cb27 Compare April 15, 2024 07:17
@lkostrowski lkostrowski marked this pull request as ready for review April 15, 2024 07:17
@lkostrowski lkostrowski requested a review from a team as a code owner April 15, 2024 07:17
@vercel Vercel
Copy link

vercel bot commented Apr 15, 2024

Deployment failed with the following error:

The value for maxDuration must be between 1 second and 10 seconds, in order to increase this limit upgrade your plan: https://vercel.com/pricing

@vercel vercel bot temporarily deployed to Preview – apps-slack-otu2 April 15, 2024 07:19 Inactive
@krzysztofzuraw krzysztofzuraw requested a review from a team April 15, 2024 07:31
@lkostrowski lkostrowski merged commit 39845f3 into main Apr 15, 2024
22 of 23 checks passed
@lkostrowski lkostrowski deleted the codegen-enums-to-types branch April 15, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzysztofzuraw krzysztofzuraw krzysztofzuraw approved these changes

Assignees

@lkostrowski lkostrowski

Labels
App: AvaTax skip changeset Attach this label to PRs which does not need changes description for the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lkostrowski @krzysztofzuraw