Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply unified UI for SC's top banner on ChatView #1138

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Apply unified UI for SC's top banner on ChatView #1138

merged 1 commit into from
Dec 3, 2024

Conversation

ykyivskyi-gl
Copy link
Contributor

MOB-3846
What was solved?
This PR adds support of unified UI for secure conversation's top banner view

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from iOS SDKs → Things to consider for newly added logs in Confluence for more information.

@ykyivskyi-gl
Copy link
Contributor Author

!squash

@sm-deployer sm-deployer force-pushed the MOB-3846-support-unified-ui-for-SC-top-banner branch from d05e79c to 5f47b28 Compare December 2, 2024 18:39
AH-MOC
AH-MOC approved these changes Dec 3, 2024
View reviewed changes
Copy link

@AH-MOC AH-MOC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ykyivskyi-gl ykyivskyi-gl merged commit a8d3c02 into feature/entry-widget-and-secure-conversations-v2 Dec 3, 2024
8 checks passed
@ykyivskyi-gl ykyivskyi-gl deleted the MOB-3846-support-unified-ui-for-SC-top-banner branch December 3, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AH-MOC AH-MOC AH-MOC approved these changes

@EgorovEI EgorovEI EgorovEI approved these changes

@igorkravchenko igorkravchenko Awaiting requested review from igorkravchenko

@rasmustautsglia rasmustautsglia Awaiting requested review from rasmustautsglia

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ykyivskyi-gl @EgorovEI @AH-MOC