Skip to content

Commit

Permalink
Remove MultiFidelityAcquisition
Browse files Browse the repository at this point in the history
Summary:
I believe this was originally designed based on the legacy MF models, but it appears to be incompatible with what MBM evolved to be. Here are a few reasons for removing it:
- Some of kwargs that are produced by `MultiFidelityAcquisition.compute_model_dependencies` (e.g., `cost_aware_utility`) are not accepted by the MFKG input constructor.
- The main kwargs that are needed by the MF acquisition functions (`cost_aware_utility`, `project`, `expand`) are readily constructed by the MF input constructors: https://github.com/pytorch/botorch/blob/main/botorch/acquisition/input_constructors.py#L1221
- We strongly discourage subclassing MBM components  and rather encourage expanding the base components to support new use cases. In this case, the MF input constructors seem to have replaced what `MultiFidelityAcquisition` originally aimed to do, while being compatible with the design philosophy.

Discovered while investigating facebook#2514

Differential Revision: D58560934
  • Loading branch information
saitcakmak authored and facebook-github-bot committed Jun 13, 2024
1 parent 1139ea0 commit 6c034ce
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 276 deletions.
100 changes: 0 additions & 100 deletions ax/models/torch/botorch_modular/multi_fidelity.py

This file was deleted.

176 changes: 0 additions & 176 deletions ax/models/torch/tests/test_multi_fidelity.py

This file was deleted.

0 comments on commit 6c034ce

Please sign in to comment.