Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor commands #488

Merged
merged 4 commits into from
Apr 25, 2024
Merged

Refactor commands #488

merged 4 commits into from
Apr 25, 2024

Conversation

sailro
Copy link
Owner

@sailro sailro commented Apr 24, 2024

Refactor commands so we can benefit from the same fallback system compared to features:

image

(here spawn and template are both commands)

@sailro sailro requested a review from solareon April 24, 2024 20:16
@solareon
Copy link
Collaborator

Gonna take a look at this one later tonight. Gotta get the laptop fired up.

solareon
solareon approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@solareon solareon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a much cleaner way to handle the commands and streamlines adding new ones in the future.

Features/FeatureRenderer.cs Show resolved Hide resolved
ConsoleCommands/ConsoleCommandWithArgument.cs Outdated Show resolved Hide resolved
ConsoleCommands/BaseListCommand.cs Show resolved Hide resolved
@sailro sailro merged commit 21868b3 into master Apr 25, 2024
1 check passed
@sailro sailro deleted the refactor-commands branch April 25, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solareon solareon solareon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sailro @solareon