Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using corepack #229

Closed
wants to merge 10 commits into from
Closed

Stop using corepack #229

wants to merge 10 commits into from

Conversation

L4Ph
Copy link
Contributor

@L4Ph L4Ph commented Nov 17, 2024

close #228

  • Enforce the use of pnpm.
  • Remove the reference to corepack from the package manager.
  • Update the version of pnpm.

Copy link

vercel bot commented Nov 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuwari-yags ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2024 5:11am

@L4Ph
Copy link
Contributor Author

L4Ph commented Nov 20, 2024

I think the settings on the Vercel side need to be corrected.
@saicaca

@saicaca
Copy link
Owner

saicaca commented Nov 30, 2024

It seems Vercel doesn't allow the use of use-node-version for some reason.
https://github.com/orgs/vercel/discussions/2436

Would the engines and pnpm.executionEnv.nodeVersion serve the same purpose?

@L4Ph
Copy link
Contributor Author

L4Ph commented Nov 30, 2024

It seems Vercel doesn't allow the use of use-node-version for some reason. https://github.com/orgs/vercel/discussions/2436

Would the engines and pnpm.executionEnv.nodeVersion serve the same purpose?

I think it's possible.
Change this from the original.

@L4Ph
Copy link
Contributor Author

L4Ph commented Nov 30, 2024

🤔

@L4Ph
Copy link
Contributor Author

L4Ph commented Nov 30, 2024

image

I tried deploying it with a Vercel account, but it passed normally...
I wonder what it is...

@saicaca
Copy link
Owner

saicaca commented Nov 30, 2024

 ERR_PNPM_INVALID_NODE_VERSION  "~22" is not a valid Node.js version

Maybe an exact version is needed🤔

@L4Ph
Copy link
Contributor Author

L4Ph commented Dec 1, 2024

Apparently there is no way to specify the node version in Vercel. (Also, it seems that it is not possible to make only Vercel be ignored.)

The commit has become too dirty, so I'll clean up the commit and submit another pull request.

@L4Ph L4Ph closed this Dec 1, 2024
@L4Ph L4Ph deleted the stop-using-corepack branch December 1, 2024 05:14
L4Ph added a commit to L4Ph/fuwari that referenced this pull request Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I want to stop using corepack.
2 participants