Platform name freebsd supports #1196
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thakns @stormshield-pj50 but any chance you can also update the docs? |
sagiegurari
reviewed
Jan 2, 2025
| @@ -308,12 +308,15 @@ It is also possible to define platform specific aliases, for example: | |||
| linux_alias = "linux_my_task" | |||
| windows_alias = "windows_my_task" | |||
| mac_alias = "mac_my_task" | |||
| freebsd_alias = "freebsd_my_task" | |||
There was a problem hiding this comment.
my hunch is that a bit more is needed for this to work.
- add the attributes in the task type
- proxy to it when platform is freebsd
if i'm not wrong.
and therefore i would also add a test for it.
without it, i feel the change you didn't won't actually impact anything. could be wrong but don't think so.
There was a problem hiding this comment.
I'm not sure how to add a relevant test for that but please take a look at my new commit and tell me if it's enough. Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Freebsd platform name.