simplify some .extend in combinat #39342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 6c58d92; changes) is ready! 🎉 |
dcoudert
reviewed
Jan 19, 2025
| @@ -1126,21 +1126,21 @@ def OA_10_205(): | |||
| GDD = [[relabel[xx] for xx in B if xx in relabel] for B in pplane if p not in B] | |||
|
|
|||
| # We turn the GDD into a PBD by extending the groups with a new point 204. | |||
| GDD.extend([[relabel[xx] for xx in G]+[204] for G in groups]) | |||
| GDD.extend([relabel[xx] for xx in G]+[204] for G in groups) | |||
There was a problem hiding this comment.
you could also avoid the [...]+[204]
from itertools import chain
GDD.extend(list(chain((relabel[xx] for xx in G), [204])) for G in groups)There was a problem hiding this comment.
but this is not shorter..
| @@ -1627,7 +1627,8 @@ def OA_10_796(): | |||
| OA = OA_relabel(OA,17,47,blocks=[OA[0]]) # making sure [46]*17 is a block | |||
| PBD = [[i*47+x for i,x in enumerate(B) if (x < 46 or i < 13)] for B in OA] | |||
| extra_point = 10000 | |||
| PBD.extend([list(range(i*47,(i+1)*47-int(i >= 13)))+[extra_point] for i in range(17)]) # Adding the columns | |||
| PBD.extend(list(range(i*47,(i+1)*47-int(i >= 13)))+[extra_point] | |||
There was a problem hiding this comment.
here also, a smart use of chain could avoid the addition of 2 lists.
| @@ -545,7 +545,7 @@ def construction_q_x(k, q, x, check=True, explain_construction=False): | |||
| # delete points. | |||
| # | |||
| # TD.extend([range(i*q,(i+1)*q) for i in range(x)]) | |||
| TD.extend([list(range(i*q,(i+1)*q))+[p2] for i in range(x,q)]) | |||
| TD.extend(list(range(i*q,(i+1)*q))+[p2] for i in range(x,q)) | |||
dcoudert
approved these changes
Jan 19, 2025
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 20, 2025
by avoiding lists inside if possible
### 📝 Checklist
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
URL: sagemath#39342
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert, Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 23, 2025
by avoiding lists inside if possible
### 📝 Checklist
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
URL: sagemath#39342
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert, Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 25, 2025
by avoiding lists inside if possible
### 📝 Checklist
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
URL: sagemath#39342
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert, Frédéric Chapoton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by avoiding lists inside if possible
📝 Checklist