Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change __call__ to _element_constructor_ in multipolynomial ring #39089

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

user202729
Copy link
Contributor

Just a trivial change. It's not recommended to override __call__.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have created tests covering the changes. (probably not needed)
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Dec 8, 2024

Documentation preview for this PR (built with commit aea07fd; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@user202729
Copy link
Contributor Author

user202729 commented Dec 8, 2024

Hm why are tests failing everywhere…? (obviously must have something to do with the coercion system etc.)


Apparently MPolynomialRing_base never had _coerce_map_from_ implemented (only the lib singular ring has), and somehow nobody notices something is wrong.

@user202729 user202729 marked this pull request as draft December 8, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant