Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention .coerce() method in coercion tour #39069

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

user202729
Copy link
Contributor

@user202729 user202729 commented Dec 2, 2024

I feel it's too hard to discover previously.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Dec 2, 2024

Documentation preview for this PR (built with commit 1ad9a17; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@fchapoton
Copy link
Contributor

Would you please break the very long lines you add in the doctests ?

@user202729
Copy link
Contributor Author

speaking of which there are two inconsistent styles

  1. Add one space of indent
    Notice that the zero tensor field is immutable, and therefore its
    components cannot be changed::

        sage: zer = M.tensor_field_module((1, 1)).zero()
        sage: zer.is_immutable()
        True
        sage: zer.set_comp()
        Traceback (most recent call last):
        ...
        ValueError: the components of an immutable element cannot be
         changed

e.g. src/sage/manifolds/differentiable/tensorfield.py

  1. Doesn't
        NotImplementedError: is_square() not implemented for
        non-constant or relational elements of Symbolic Ring

e.g. src/sage/arith/misc.py

Just nitpicking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants