Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics: update Privacy policy for Spindl + refactor legal pages #2840

Merged
merged 6 commits into from
Nov 22, 2023

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Nov 21, 2023

What it solves

I've cleaned up the components folder a little bit and remove unnecessary directories.

Also updated the Privacy Policy to include information about Spindl and the tracking of signer addresses.

How to test it

Just click through pages like Terms, Imprint, Cookie policy etc and check that nothing has changed visually.

Copy link

github-actions bot commented Nov 21, 2023

Branch preview

✅ Deploy successful!

https://refactor_pages--walletweb.review-wallet-web.5afe.dev

Copy link

github-actions bot commented Nov 21, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Nov 21, 2023

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 1.39 MB (-27 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/cookie 8.88 KB (🔴 +2.56 KB) 1.4 MB
/imprint 1.41 KB (🟢 -14 B) 1.39 MB
/licenses 5.13 KB (🟢 -15 B) 1.4 MB
/privacy 15.87 KB (🔴 +3.19 KB) 1.41 MB
/terms 10.06 KB (🟢 -17 B) 1.4 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Nov 21, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.9% (-0.03% 🔻)
9978/13147
🔴 Branches
50.14% (+0% 🔼)
2032/4053
🔴 Functions
58.69% (-0.04% 🔻)
1493/2544
🟡 Lines
77.48% (-0.02% 🔻)
9016/11637
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / abTesting.ts
75% (-25% 🔻)
100%
66.67% (-33.33% 🔻)
83.33% (-16.67% 🔻)
🟡
... / SignForm.tsx
60%
39.13% (-0.87% 🔻)
33.33% 60.47%
🟡
... / index.tsx
72.55% (-0.53% 🔻)
58.33% (-3.21% 🔻)
53.33%
73.2% (-0.54% 🔻)
🟢
... / useAbTesting.ts
93.75% (-6.25% 🔻)
75% (-25% 🔻)
100%
92.86% (-7.14% 🔻)

Test suite run success

1095 tests passing in 154 suites.

Report generated by 🧪jest coverage report action from e2b76a4

@katspaugh katspaugh added this to the 1.3.0 milestone Nov 21, 2023
@katspaugh katspaugh changed the title Refactor: move legal pages from components to pages Analytics: update Privacy policy for Spindl + refactor legal pages Nov 21, 2023
@francovenica
Copy link
Contributor

francovenica commented Nov 21, 2023

I don't consider this issues, but different behaviour from how it is now in prod.
I don't mind deploying them as they are. Still for the record:

In "Privacy". In Prod these links work as anchors: they scroll you to the point you want to see.
In this PR they refresh the page completely before scrolling you down
image

Some sub-bulletpoints have a larger font size than what it is in Prod. Here in privacy again:
image
image

@katspaugh
Copy link
Member Author

Fixed the links, the font changes are intended.

@francovenica
Copy link
Contributor

The links are still reloading the page. The URL that loads for the links it seems they are being tracked I guess?
Let me know if it is intentional
image

@katspaugh
Copy link
Member Author

It's not intentional, some weird stuff is going on with these links.

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh
Copy link
Member Author

Fixed by making them JS links.

@katspaugh katspaugh merged commit 9a7978c into dev Nov 22, 2023
15 checks passed
@katspaugh katspaugh deleted the refactor-pages branch November 22, 2023 08:27
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants