-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analytics: update Privacy policy for Spindl + refactor legal pages #2840
Conversation
Branch preview✅ Deploy successful! https://refactor_pages--walletweb.review-wallet-web.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Five Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
Coverage report
Show files with reduced coverage 🔻
Test suite run success1095 tests passing in 154 suites. Report generated by 🧪jest coverage report action from e2b76a4 |
2a8b528
to
7447611
Compare
Fixed the links, the font changes are intended. |
It's not intentional, some weird stuff is going on with these links. |
2f81345
to
e2b76a4
Compare
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Fixed by making them JS links. |
What it solves
I've cleaned up the components folder a little bit and remove unnecessary directories.
Also updated the Privacy Policy to include information about Spindl and the tracking of signer addresses.
How to test it
Just click through pages like Terms, Imprint, Cookie policy etc and check that nothing has changed visually.