Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip recovery transactions #2837

Merged
merged 1 commit into from
Nov 21, 2023
Merged

feat: skip recovery transactions #2837

merged 1 commit into from
Nov 21, 2023

Conversation

iamacook
Copy link
Member

What it solves

Resolves #2763

How this PR fixes it

A new flow for skipping recovery transactions has been added which is opened via the "Skip" buttons in the transaction list.

Note: a hard refresh is required after skipping is executed but this will be fixed in a follow up PR.

How to test it

  1. Propose a recovery attempt.
  2. Skip it via the transaction list.
  3. Refresh and observe no more recovery attempts listed.

Screenshots

skip-recovery

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook requested a review from katspaugh November 21, 2023 11:11
@iamacook iamacook linked an issue Nov 21, 2023 that may be closed by this pull request
7 tasks
Copy link

github-actions bot commented Nov 21, 2023

Branch preview

✅ Deploy successful!

https://recovery_skip--walletweb.review-wallet-web.5afe.dev

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.51% (-0.02% 🔻)
10476/13873
🔴 Branches 50.42% 2147/4258
🔴 Functions
58.5% (-0.02% 🔻)
1576/2694
🟡 Lines
77.05% (-0.02% 🔻)
9478/12301
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / transaction.ts
92.96% (-5.53% 🔻)
95.65%
92.86% (-7.14% 🔻)
92.06% (-6.21% 🔻)

Test suite run success

1193 tests passing in 168 suites.

Report generated by 🧪jest coverage report action from 41224f8

@iamacook iamacook merged commit 404aa9c into recovery-epic Nov 21, 2023
11 checks passed
@iamacook iamacook deleted the recovery-skip branch November 21, 2023 12:17
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Recovery] Transaction queue - group skipped transactions
2 participants