Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics: track app version in all events #2831

Merged
merged 5 commits into from
Nov 21, 2023
Merged

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Nov 21, 2023

What it solves

This PR adds a new custom tracking dimension, appVersion, which look like v1.22.2. Trackign the app version will help compare changes across releases.

How to test it

Trigger any GTM event and observe that the payload contains the version number in the appVersion field.

katspaugh and others added 4 commits November 20, 2023 16:11
* Fix: remove deprecated mobile pairing

* Fix accounts[0] and Delete Account

* Update onboard package

* Update env vars
* Fix: add help link in footer

* External link
@katspaugh katspaugh requested a review from alicecha November 21, 2023 09:26
Copy link

github-actions bot commented Nov 21, 2023

Branch preview

✅ Deploy successful!

https://track_version--walletweb.review-wallet-web.5afe.dev

Copy link

github-actions bot commented Nov 21, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Nov 21, 2023

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.39 MB (🟡 +14 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link

github-actions bot commented Nov 21, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.97% (+0.06% 🔼)
9989/13148
🔴 Branches
50.19% (+0.02% 🔼)
2034/4053
🔴 Functions
58.77% (+0.04% 🔼)
1495/2544
🟡 Lines
77.55% (+0.05% 🔼)
9025/11638

Test suite run success

1098 tests passing in 154 suites.

Report generated by 🧪jest coverage report action from 4bd4213

@katspaugh katspaugh changed the title Feat: track app version in all events Analytics: track app version in all events Nov 21, 2023
@katspaugh katspaugh changed the base branch from dev to analytics November 21, 2023 10:29
@katspaugh katspaugh merged commit cec8fed into analytics Nov 21, 2023
15 checks passed
@katspaugh katspaugh deleted the track-version branch November 21, 2023 10:29
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2023
@katspaugh katspaugh added this to the 1.23.0 milestone Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant