-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Add Chrome version to smoke tests workflow #2826
Conversation
Branch preview✅ Deploy successful! https://add_chrome_version--walletweb.review-wallet-web.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Coverage report
Test suite run success1098 tests passing in 154 suites. Report generated by 🧪jest coverage report action from cf7a008 |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
c151423
to
9ae10f6
Compare
More context on this for posterity: |
What it solves
Resolves #2825
How this PR fixes it
Recently it was noticed that some machines started to fail when running Cypress tests in parallel. This was due to different version of Chrome passed by random machines, where Cypress requires all machines pass identical environment. The fix was to use specific version of Chrome and add this step to our test workflows.
Part of this task also included increasing number of test retries to reduce flaky tests. This will be observed and adjusted as needed.