Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: WC verification wording #2798

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Fix: WC verification wording #2798

merged 1 commit into from
Nov 20, 2023

Conversation

katspaugh
Copy link
Member

What it solves

Adjust the warning as per Derek's request.

🙏for implementing Verify API - caveat
your language for “mismatch” is a bit strong and also wrong - we do not flag this scenario as “high risk”. Can you pls make the messaging a bit more clear?

@katspaugh katspaugh requested a review from schmanu November 13, 2023 15:16
Copy link

github-actions bot commented Nov 13, 2023

Branch preview

✅ Deploy successful!

https://fix_wc_warning--walletweb.review-wallet-web.5afe.dev

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.04% (+0.02% 🔼)
10109/13472
🔴 Branches
49.54% (+0.02% 🔼)
2055/4148
🔴 Functions
57.46% (+0.04% 🔼)
1498/2607
🟡 Lines
76.61% (+0.02% 🔼)
9145/11937

Test suite run success

1105 tests passing in 155 suites.

Report generated by 🧪jest coverage report action from 74a578f

@liliya-soroka
Copy link
Member

We tried to go with a more general message because we have only an invalid state from the wallet connect without the original problem.
The case "has a domain that does not match the sender of this request" might be one of the reasons for unverified apps. Would it not be confusing in case of other reasons for "unverified" by Wallet Connect?

@katspaugh
Copy link
Member Author

@liliya-soroka they verify only domains, so that message is adequate. See https://docs.walletconnect.com/web3wallet/verify

@liliya-soroka
Copy link
Member

Ok, agreed, verified

@katspaugh katspaugh merged commit 0b5939c into dev Nov 20, 2023
11 of 13 checks passed
@katspaugh katspaugh deleted the fix-wc-warning branch November 20, 2023 13:00
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2023
@katspaugh katspaugh added this to the 1.23.0 milestone Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants