Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pending state for social login #2785

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Nov 9, 2023

What it solves

Currently the login button only becomes disabled but does not indicate that the login / account creation is in progress.

How this PR fixes it

  • Adds a pending state to the social login button

How to test it

  • Login with google on i.e. the Welcome Page

Screenshots

Screen.Recording.2023-11-09.at.16.58.58.mov

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Nov 9, 2023

Branch preview

✅ Deploy successful!

https://fix_pending_social_login--walletweb.review-wallet-web.5afe.dev

@schmanu schmanu requested a review from usame-algan November 9, 2023 16:08
Copy link

github-actions bot commented Nov 9, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Nov 9, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 75.08% 10089/13438
🔴 Branches
49.63% (+0.02% 🔼)
2052/4135
🔴 Functions 57.53% 1498/2604
🟡 Lines 76.65% 9125/11905

Test suite run success

1105 tests passing in 155 suites.

Report generated by 🧪jest coverage report action from 1855023

@schmanu
Copy link
Member Author

schmanu commented Nov 9, 2023

@francovenica
I will merge this into the RC as this PR deployment does not work due to the redirect URI not being allowlisted.

Please QA it there :)

@schmanu schmanu merged commit 06f78a1 into dev Nov 9, 2023
13 checks passed
@schmanu schmanu deleted the fix-pending-social-login branch November 9, 2023 16:50
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants