Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust overview widget on dashboard for new design #2782

Merged
merged 6 commits into from
Nov 10, 2023

Conversation

usame-algan
Copy link
Member

What it solves

Updates the dashboard overview widget to support easy on-ramping

Figma: https://www.figma.com/file/ptTs6lDBeUuLNySroJ5PiF/Web-Master-File?node-id=8786%3A68251&mode=dev

How this PR fixes it

How to test it

  1. Open a Safe
  2. Go to the dashboard
  3. Observe the updated design
  4. Switch to a network where the Ramp Network app is activated
  5. Observe a "Buy crypto" button

Screenshots

Screenshot 2023-11-09 at 13 57 10 Screenshot 2023-11-09 at 13 57 27

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@usame-algan usame-algan requested a review from schmanu November 9, 2023 12:57
Copy link

github-actions bot commented Nov 9, 2023

Branch preview

✅ Deploy successful!

https://dashboard_overview--walletweb.review-wallet-web.5afe.dev

Copy link

github-actions bot commented Nov 9, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Nov 9, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 75.06% 10105/13463
🔴 Branches 49.59% 2055/4144
🔴 Functions 57.48% 1498/2606
🟡 Lines 76.63% 9141/11929

Test suite run success

1105 tests passing in 155 suites.

Report generated by 🧪jest coverage report action from a66b7d2

Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that in Dark mode the icons do not adjust their color.

public/images/common/arrow-se.svg Outdated Show resolved Hide resolved
public/images/common/arrow-top-right.svg Outdated Show resolved Hide resolved
@usame-algan usame-algan requested a review from schmanu November 9, 2023 13:55
Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The app is also listed now on staging and the button works :)

@katspaugh
Copy link
Member

The skeletons need some adjustments, it jumps twice when loading.

Screen.Recording.2023-11-09.at.16.24.32.mov

@schmanu schmanu mentioned this pull request Nov 9, 2023
@francovenica
Copy link
Contributor

For mobile if the "Buy" button is present is all too cramped:
image

Question just out of curiosity: why the "Buy" is an "a" tag, the "Send" is a button and the "Receive" is a button wrapped in a div?

@usame-algan
Copy link
Member Author

usame-algan commented Nov 10, 2023

I updated the loading state and mobile view accordingly
Screenshot 2023-11-10 at 10 59 44

Screen.Recording.2023-11-10.at.10.59.56.mov

Question just out of curiosity: why the "Buy" is an "a" tag, the "Send" is a button and the "Receive" is a button wrapped in a div?

The Buy Crypto button is an a because it links to a different page. The Receive button is wrapped in a div because we are reusing a wrapper component that adds an onClick handler around its children so there has to be some element to hold that.

@katspaugh
Copy link
Member

Can you make Send and Receive be on the same line, and Buy crypto on a different line?

@usame-algan
Copy link
Member Author

Changed it like so on mobile:
Screenshot 2023-11-10 at 11 40 57

@usame-algan usame-algan merged commit 5399c1a into dev Nov 10, 2023
13 checks passed
@usame-algan usame-algan deleted the dashboard-overview branch November 10, 2023 11:34
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants