-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable recovery flow structure #2775
Conversation
Branch preview❌ Deploy failed! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Coverage report
Show new covered files 🐣
Test suite run success1138 tests passing in 160 suites. Report generated by 🧪jest coverage report action from 7244e2e |
{ | ||
label: 'Recovery', | ||
href: AppRoutes.settings.recovery, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I intend merge the settings areas according to the design in a separate PR.
ESLint Summary View Full Report
Report generated by eslint-plus-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left a few small design comments. There is also a test failing in the useLoadRecovery
hook
<Typography variant="body2" mt={2}> | ||
For security reasons, we highly recommend adding an email address. You will be notified once a Guardian | ||
initiates recovery and be able to reject it if it's a malicious attempt. | ||
</Typography> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Figma design has a button "Got it" on this hint, I assume to close it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TanyaEfremova, should this button close the widget indefinitely or only in the current flow? We don't allow users to close hints in any other flows (I personally don't think we should include this).
src/components/tx-flow/flows/EnableRecovery/EnableRecoveryFlowIntro.tsx
Outdated
Show resolved
Hide resolved
src/components/tx-flow/flows/EnableRecovery/EnableRecoveryFlowReview.tsx
Outdated
Show resolved
Hide resolved
src/components/tx-flow/flows/EnableRecovery/EnableRecoveryFlowSettings.tsx
Outdated
Show resolved
Hide resolved
ESLint Summary View Full Report
Report generated by eslint-plus-action |
What it solves
Resolves #2760
How this PR fixes it
This adds a new transaction flow for enabling recovery from a template "Recovery" section of the settings (later to be moved).
How to test it
Open the "Recovery" section of a Safe and observe a new area that allows for the enabling of recovery. Enabling will take you through a new flow according to the designs.
Screenshots
Checklist