Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize docker image #2771

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Nov 8, 2023

  • Reduce size by using multistage builds
  • Run yarn build on the build process and not when the docker image starts (it can take a few minutes to complete)

- Reduce size by using multistage builds
- Run `yarn build` on the build process and not when the docker image starts (it can take a few minutes to complete)
Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! I assume you have tested it locally?

@Uxio0
Copy link
Member Author

Uxio0 commented Nov 8, 2023

Yes, it's tested locally

@katspaugh katspaugh merged commit af97244 into safe-global:dev Nov 8, 2023
2 of 10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2023
@Uxio0 Uxio0 deleted the optimize-docker-image branch November 8, 2023 17:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants