-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: recovery dashboard widget #2768
Conversation
Branch preview✅ Deploy successful! https://dashboard_widget--walletweb.review-wallet-web.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Coverage report
Show files with reduced coverage 🔻
Test suite run success1137 tests passing in 159 suites. Report generated by 🧪jest coverage report action from 0fa4d42 |
cy.get('p').contains('1').should('exist') | ||
cy.get('p').contains('2').should('exist') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was failing for some reason. Fixed after consultation with @mike10ca.
I've updated the colour in bd7fa18. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
<Typography variant="h4" className={css.title}> | ||
Introducing account recovery{' '} | ||
</Typography> | ||
<Chip label="New" color={isDarkMode ? 'primary' : 'secondary'} size="small" className={css.chip} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we create a static-primary
color in our theme the same way we have static-main
so we don't have to use a hook here. Lets do it as a separate PR though.
return ( | ||
<WidgetContainer> | ||
<Typography component="h2" variant="subtitle1" className={css.label}> | ||
New in {'Safe{Wallet}'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: The Figma design says New in Safe
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wording is incorrect in the design. This is a Safe{Wallet} feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind removing this widget but for visibility I would suggest we document it somewhere.
What it solves
Resolves #2753
How this PR fixes it
The "New in Safe{Wallet}" section of the dashboard has been updated with a recovery featuring widget as per design. A new
RELAYING
feature has also been added on the staging Client Gateway, enabled on Goerli, which display of the widget depends on.Note: the button has no functionality until 2760 is implemented.
How to test it
Open Goerli on staging and observe the new widget.
Screenshots
Checklist