Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: recovery dashboard widget #2768

Merged
merged 7 commits into from
Nov 20, 2023
Merged

feat: recovery dashboard widget #2768

merged 7 commits into from
Nov 20, 2023

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Nov 8, 2023

What it solves

Resolves #2753

How this PR fixes it

The "New in Safe{Wallet}" section of the dashboard has been updated with a recovery featuring widget as per design. A new RELAYING feature has also been added on the staging Client Gateway, enabled on Goerli, which display of the widget depends on.

Note: the button has no functionality until 2760 is implemented.

How to test it

Open Goerli on staging and observe the new widget.

Screenshots

image

image

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook requested a review from usame-algan November 8, 2023 08:31
Copy link

github-actions bot commented Nov 8, 2023

Branch preview

✅ Deploy successful!

https://dashboard_widget--walletweb.review-wallet-web.5afe.dev

@iamacook iamacook marked this pull request as draft November 8, 2023 08:32
Copy link

github-actions bot commented Nov 8, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Nov 8, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.18% (-0.02% 🔻)
10215/13587
🔴 Branches
49.88% (-0.02% 🔻)
2083/4176
🔴 Functions
57.74% (-0.04% 🔻)
1518/2629
🟡 Lines
76.73% (-0.02% 🔻)
9241/12044
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / abTesting.ts
75% (-25% 🔻)
100%
66.67% (-33.33% 🔻)
83.33% (-16.67% 🔻)
🟢
... / useAbTesting.ts
93.75% (-6.25% 🔻)
75% (-25% 🔻)
100%
92.86% (-7.14% 🔻)

Test suite run success

1137 tests passing in 159 suites.

Report generated by 🧪jest coverage report action from 0fa4d42

Comment on lines 149 to 150
cy.get('p').contains('1').should('exist')
cy.get('p').contains('2').should('exist')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was failing for some reason. Fixed after consultation with @mike10ca.

@iamacook iamacook marked this pull request as ready for review November 8, 2023 09:36
@iamacook iamacook mentioned this pull request Nov 13, 2023
3 tasks
@iamacook iamacook changed the base branch from dev to recovery-epic November 13, 2023 08:13
@iamacook iamacook changed the base branch from recovery-epic to recover-state November 13, 2023 08:14
@liliya-soroka
Copy link
Member

incorrect color for the New label
image
design:
image

@iamacook
Copy link
Member Author

incorrect color for the New label image design: image

I've updated the colour in bd7fa18.

Base automatically changed from recover-state to recovery-epic November 13, 2023 15:57
Copy link

github-actions bot commented Nov 13, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

<Typography variant="h4" className={css.title}>
Introducing account recovery{' '}
</Typography>
<Chip label="New" color={isDarkMode ? 'primary' : 'secondary'} size="small" className={css.chip} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we create a static-primary color in our theme the same way we have static-main so we don't have to use a hook here. Lets do it as a separate PR though.

return (
<WidgetContainer>
<Typography component="h2" variant="subtitle1" className={css.label}>
New in {'Safe{Wallet}'}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The Figma design says New in Safe here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording is incorrect in the design. This is a Safe{Wallet} feature.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind removing this widget but for visibility I would suggest we document it somewhere.

@iamacook iamacook merged commit ce2702a into recovery-epic Nov 20, 2023
8 of 11 checks passed
@iamacook iamacook deleted the dashboard-widget branch November 20, 2023 09:33
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Recovery] Dashboard enable widget
3 participants