Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add events for export pk #2766

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

usame-algan
Copy link
Member

What it solves

Part of #2452

How this PR fixes it

  • Adds new events for the export pk flow
  • Reveal private key when the user presses the button
  • Export private key successful when the user successfully types in the password
  • Export private key error if the password was wrong or the validation failed for another reason
  • Toggle see private key when the user toggles to see their private key
  • Copy private key when the user copies their pk

How to test it

  1. Open Safe
  2. Login with social
  3. Create a password
  4. Go through the export pk flow and observe the above mentioned events

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@usame-algan usame-algan requested a review from schmanu November 7, 2023 15:28
Copy link

github-actions bot commented Nov 7, 2023

Branch preview

✅ Deploy successful!

https://seedless_events--walletweb.review-wallet-web.5afe.dev

Copy link

github-actions bot commented Nov 7, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

return (
<ModalDialog open={open} onClose={handleClose}>
<DialogTitle>
<Typography variant="h6" fontWeight={700}>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was causing some MUI errors in the console

Copy link

github-actions bot commented Nov 7, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.07% (-0.02% 🔻)
10058/13398
🔴 Branches
49.64% (-0.02% 🔻)
2052/4134
🔴 Functions
57.59% (-0.04% 🔻)
1495/2596
🟡 Lines
76.62% (-0.02% 🔻)
9098/11874
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / abTesting.ts
75% (-25% 🔻)
100%
66.67% (-33.33% 🔻)
83.33% (-16.67% 🔻)
🟢
... / useAbTesting.ts
93.75% (-6.25% 🔻)
75% (-25% 🔻)
100%
92.86% (-7.14% 🔻)

Test suite run success

1102 tests passing in 154 suites.

Report generated by 🧪jest coverage report action from 9c42dde

@usame-algan usame-algan merged commit 4fbfa1b into web3authcoresdk Nov 8, 2023
11 checks passed
@usame-algan usame-algan deleted the seedless-events branch November 8, 2023 14:18
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants