Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merge service workers into pwa #2749

Closed
wants to merge 3 commits into from
Closed

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Nov 7, 2023

What it solves

Merged serviceworker for seedless onboarding with the notifications service worker.

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@schmanu schmanu requested a review from usame-algan November 7, 2023 11:03
Copy link

github-actions bot commented Nov 7, 2023

Branch preview

⏳ Deploying a preview site...

Copy link

github-actions bot commented Nov 7, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Nov 7, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.15% (+0.06% 🔼)
10051/13375
🔴 Branches
49.66% (+0.02% 🔼)
2053/4134
🔴 Functions
57.73% (+0.02% 🔼)
1498/2595
🟡 Lines
76.68% (+0.06% 🔼)
9089/11853
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / index.tsx
71.43% 0% 0% 83.33%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / useSocialWallet.ts
34.43% (-11.03% 🔻)
0% 0%
32.69% (-8.33% 🔻)
🟢
... / index.tsx
80% (-3.33% 🔻)
0% 0% 100%

Test suite run success

1102 tests passing in 154 suites.

Report generated by 🧪jest coverage report action from 7648cfd

@schmanu
Copy link
Member Author

schmanu commented Nov 7, 2023

Closing in favor of #2750

@schmanu schmanu closed this Nov 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2023
@katspaugh katspaugh deleted the seedless-merge-sw branch December 13, 2023 08:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant