Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: redirect /wc URL #2747

Merged
merged 6 commits into from
Nov 9, 2023
Merged

Fix: redirect /wc URL #2747

merged 6 commits into from
Nov 9, 2023

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Nov 7, 2023

What it solves

Resolves reown-com/appkit#1455

How this PR fixes it

We will be redirecting the /wc?uri=<WC_URI> URL to /home?safe=<LAST_OPENED_SAFE>&wc=<WC_URI>.
If no Safe has been previously opened, it will redirect to /welcome.

How to test

  • Go to http://lab.web3modal.com
  • Choose Connect -> All wallets -> Safe -> Web app
  • Copy the /wc?uri=<WC_URI> part from the opened page
  • Open this branch's URL and add /wc?uri=<WC_URI> to the URL

@katspaugh katspaugh requested a review from usame-algan November 7, 2023 08:51
Copy link

github-actions bot commented Nov 7, 2023

Branch preview

✅ Deploy successful!

https://wc--walletweb.review-wallet-web.5afe.dev

Copy link

github-actions bot commented Nov 7, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Nov 7, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.15% (-0.03% 🔻)
9457/12584
🔴 Branches
49.45% (-0.03% 🔻)
1932/3907
🔴 Functions
57.88% (-0.04% 🔻)
1422/2457
🟡 Lines
76.84% (-0.02% 🔻)
8563/11144
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / utils.ts
51.22% (-4.88% 🔻)
36.36%
28.57% (-7.14% 🔻)
51.72% (-3.45% 🔻)
🟢
... / useWalletConnectSearchParamUri.ts
92.86% (-7.14% 🔻)
100% (+10% 🔼)
100% 100%

Test suite run success

1046 tests passing in 143 suites.

Report generated by 🧪jest coverage report action from 3042f96

@katspaugh
Copy link
Member Author

@francovenica this should ideally go live together with seedless.

usame-algan
usame-algan previously approved these changes Nov 8, 2023
@liliya-soroka
Copy link
Member

liliya-soroka commented Nov 9, 2023

We will be redirecting the /wc?uri=<WC_URI> URL to /home?safe=<LAST_OPENED_SAFE>&wc=<WC_URI> - confirmed
image

@liliya-soroka
Copy link
Member

liliya-soroka commented Nov 9, 2023

If no Safe has been previously opened, it will redirect to /welcome. - confirmed
what is your opinion about opening the wallet connect modal to show the user why the connection was not established in this case?

@katspaugh katspaugh merged commit b2ba82d into dev Nov 9, 2023
12 of 13 checks passed
@katspaugh katspaugh deleted the wc branch November 9, 2023 10:44
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Safe Wallet redirecting to a 404
3 participants