Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reload app when setting password #2741

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Conversation

usame-algan
Copy link
Member

What it solves

Part of #2452

How this PR fixes it

Reloads the app when setting a password so that the state is updated. This is a workaround because there is no observable state for when the password is set or when MFA is enabled.

How to test it

  1. Open the app
  2. Login with Google
  3. Go to Security & Login settings
  4. Set or update the password
  5. Observe the page reloads after successful submission

@usame-algan usame-algan requested a review from katspaugh November 3, 2023 10:51
Copy link

github-actions bot commented Nov 3, 2023

Branch preview

✅ Deploy successful!

https://password_reloadd--walletweb.review-wallet-web.5afe.dev

Copy link

github-actions bot commented Nov 3, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Nov 3, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.24% (-0.02% 🔻)
10045/13351
🔴 Branches 49.72% 2051/4125
🔴 Functions
57.84% (-0.02% 🔻)
1497/2588
🟡 Lines
76.75% (-0.02% 🔻)
9081/11832
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / index.tsx
44.78% (-1.26% 🔻)
19.35%
27.27% (-2.73% 🔻)
46.77% (-1.5% 🔻)

Test suite run success

1100 tests passing in 153 suites.

Report generated by 🧪jest coverage report action from 00953c7

@usame-algan usame-algan merged commit 13618c3 into web3authcoresdk Nov 3, 2023
7 checks passed
@usame-algan usame-algan deleted the password-reloadd branch November 3, 2023 12:19
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants