-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update to new recommended nonce endpoint #2737
Conversation
Branch preview✅ Deploy successful! https://rec_nonce_change--walletweb.review-wallet-web.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Coverage report
Show files with reduced coverage 🔻
Test suite run success1046 tests passing in 143 suites. Report generated by 🧪jest coverage report action from dd1c65d |
So the ticket is labeled as "in progress" but since is in ready for QA I still checked it. I tried in a sepolia safe play with the nonces. Create tx Looks good. I'll keep the ticket here until the Work in progress tag is removed. If anything changes let me know and I'll re check |
We can merge it as soon as its ready on prod CGW |
Did a quick check again, same cases in safes 1.1.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why so many changes? The only necessary one was fetchRecommendedParams
-> getNonces
on one single line.
What it solves
Use the new recommended nonce endpoint on the CGW
How this PR fixes it
/nonces
endpointHow to test it
CGW ticket - safe-global/safe-client-gateway#681
Checklist