Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hide Security&Login from settings if not a social signer #2734

Merged
merged 5 commits into from
Nov 2, 2023

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Nov 2, 2023

What it solves

Part of #2452

How this PR fixes it

  • Hides Security & Login on the settings page if not logged in with a social signer
  • Enables the Continue with Google button if the user closes the password recovery modal
  • Shows part of the supported networks message in a tooltip on the welcome page
  • Closes the wallet popover when the recovery modal opens

How to test it

  1. Open the settings page
  2. Observe no Security & Login navigation item
  3. Login with social signer
  4. Observe a Security & Login navigation item
  5. Set a password for the social signer and try to login from a different browser
  6. Abort the password recovery modal
  7. Observe the Continue with Google button on the welcome page becomes enabled again

Screenshots

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@usame-algan usame-algan requested a review from katspaugh November 2, 2023 13:35
Copy link

github-actions bot commented Nov 2, 2023

Branch preview

✅ Deploy successful!

https://qa_fixes_2--walletweb.review-wallet-web.5afe.dev

Copy link

github-actions bot commented Nov 2, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Nov 2, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.25% (+0.04% 🔼)
10026/13324
🔴 Branches
49.71% (+0.05% 🔼)
2043/4110
🔴 Functions
57.72% (+0.03% 🔼)
1491/2583
🟡 Lines
76.78% (+0.03% 🔼)
9066/11808
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / index.tsx
100% 100% 100% 100%
🟢
... / index.tsx
100% 100% 100% 100%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / abTesting.ts
75% (-25% 🔻)
100%
66.67% (-33.33% 🔻)
83.33% (-16.67% 🔻)
🟢
... / index.tsx
83.82% (-1.47% 🔻)
81.25% (-4.46% 🔻)
60% (-3.64% 🔻)
87.3% (-1.59% 🔻)
🟢
... / useAbTesting.ts
93.75% (-6.25% 🔻)
75% (-25% 🔻)
100%
92.86% (-7.14% 🔻)

Test suite run success

1100 tests passing in 153 suites.

Report generated by 🧪jest coverage report action from 844f8ff

@usame-algan usame-algan merged commit c81b9fb into web3authcoresdk Nov 2, 2023
7 checks passed
@usame-algan usame-algan deleted the qa-fixes-2 branch November 2, 2023 16:00
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants