Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Seedless-Onboarding] fix: login error handling #2730

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Nov 1, 2023

What it solves

Login errors are caught and ignored.

How this PR fixes it

  • Calls logError and throws a new Error.
  • Displays the error in the login screens

How to test it

  • Break the local config by configuring a wrong verifier ID or block the network requests
  • Try to login
  • Witness new errors

Screenshots

Screenshot 2023-11-01 at 18 29 49
Screenshot 2023-11-01 at 18 29 32

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@schmanu schmanu requested a review from usame-algan November 1, 2023 17:26
Copy link

github-actions bot commented Nov 1, 2023

Branch preview

✅ Deploy successful!

https://login_error_handling--walletweb.review-wallet-web.5afe.dev

Copy link

github-actions bot commented Nov 1, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Nov 1, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.2% (-0% 🔻)
9996/13292
🔴 Branches
49.66% (+0.01% 🔼)
2037/4102
🔴 Functions 57.68% 1487/2578
🟡 Lines
76.75% (-0% 🔻)
9041/11780
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / SocialWalletService.ts
57.97% (-0.85% 🔻)
50% 46.15%
59.09% (-0.91% 🔻)

Test suite run success

1094 tests passing in 152 suites.

Report generated by 🧪jest coverage report action from fa81867

@usame-algan usame-algan merged commit e681310 into web3authcoresdk Nov 2, 2023
6 of 7 checks passed
@usame-algan usame-algan deleted the login-error-handling branch November 2, 2023 09:01
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants