Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.21.0 #2727

Merged
merged 9 commits into from
Nov 2, 2023
Merged

Release 1.21.0 #2727

merged 9 commits into from
Nov 2, 2023

Conversation

katspaugh
Copy link
Member

Features

Bug fixes

Tests

katspaugh and others added 7 commits October 30, 2023 14:50
@katspaugh
Feat: pinned apps on top of all apps + rm list view switch (#2699)
61f0568 
* Feat: pinned apps on top of all apps

* Fix tests

* Rm list view switch

* Update e2e tests

* push -> replace

* Fix e2e
@mike10ca
Tests: Fix Cypress tests (#2706)
fd3ba32 
* Fix Cypress tests
* Update tests logic
@mike10ca
Tests: Update skipped tests (#2723)
481e6a3 
* Update skipped tests
* Fix permissions tests
* Fix NFTS tests
@katspaugh
Fix: render mobile pairing correctly (#2718)
391bc56
@katspaugh
Fix: soften fallback handler warning (#2716)
236c541 
* Fix: custom fallback handler warning

* Adjust style

* Fix unit tests
@katspaugh
Fix: adjust WalletConnect events (#2717)
5d7e2dc 
* Fix: adjust WalletConnect events

* Cut off error details

* Don't swallow chain switch errors

* Fix nested p warning

* Fix tests

* Split errors

* Style wc error

* Connect/disconnect timer to 1s

* Fix: safe logo for WC

* Show unsupported chain error

* Fix: WC url for the origin field

* Redirect WC Safe App to open popup

* Fix error overflow

* Fix tests

* Fix: pass app id to offchain message flow

* A better wrong chain message
@katspaugh
1.21.0
90aaa5c
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023 •
edited
Loading

Branch preview

✅ Deploy successful!

https://release_1_21_0--walletweb.review-wallet-web.5afe.dev

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements
75.17% (-0.15% 🔻)
 9461/12586
🔴 Branches
49.45% (-0.02% 🔻)
 1934/3911
🔴 Functions
58% (-0.34% 🔻)
 1425/2457
🟡 Lines
76.84% (-0.11% 🔻)
 8565/11147
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🔴
... / QRModal.tsx
 46.15% 0% 0% 57.14%
🔴
... / PairingQRCode.tsx
 43.48% 0% 0% 45.45%
🟢
... / index.tsx
 75% 0% 0% 85.71%
🟢
... / PairingDescription.tsx
 85.71% 100% 0% 100%
🟡
... / index.tsx
 60% 50% 33.33% 66.67%
🟢
... / PairingDeprecationWarning.tsx
 75% 100% 0% 100%
🟢
... / tracking.ts
 85.71% 0% 100% 83.33%
🟢
... / walletconnect.ts
 75% 100% 100% 100%
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🟢
... / WalletConnectWallet.ts
90.48% (+0.59% 🔼)
 90.48%
84% (-0.62% 🔻)
92.5% (+0.74% 🔼)
🟢
... / WalletConnectContext.tsx
 100%
86.36% (-6.49% 🔻)
84.62% (+4.62% 🔼)
 100%
🟢
... / useSafeWalletProvider.tsx
79.44% (-1.09% 🔻)
55% (-4.09% 🔻)
65.38% (-1.28% 🔻)
81.19% (-1.05% 🔻)
🟢
... / useRemoteSafeApps.ts
90.91% (-3.03% 🔻)
 66.67%
90.91% (-9.09% 🔻)
92.86% (-3.57% 🔻)
🟢
... / index.tsx
96% (-0.77% 🔻)
90.91% (-2.42% 🔻)
 100% 100%

Test suite run success

1046 tests passing in 143 suites.

Report generated by 🧪jest coverage report action from 054b53b

@francovenica
Copy link
Contributor

The logo in the onboard looks like this:
image

@francovenica
Copy link
Contributor

francovenica commented Nov 2, 2023 •
edited
Loading

I connected with Opensea and the tab in the browser got in a state were the icon flickers constantly. The connection was done, no other messages should be pending of signing, so there should be no reason for the icon to flicker like that.

I tried in prod and didn't happened there.

Beyond that flickr, no further issues seem to be regarding connecting to a Dapp
RC1

EDIT: I got the same issue duing a swap in the "Swap" Dapp as well

@francovenica
Copy link
Contributor

There is an issue when, if you try to upload a file (like import in the address book) the pages refreshes and the URL has a new parameter that idk where it comes from. This doesn't happen in prod

Navigate to the Address book
Click on import
Click on the "choose a file" link to open the file explorer.

RC2

@francovenica
Copy link
Contributor

The rest of the RC is fine. I did a smoke navigating the page, creating safes, signgin and executing tx with different browsers... Looks good

@katspaugh katspaugh mentioned this pull request Nov 2, 2023
Merged
@liliya-soroka
Copy link
Member

liliya-soroka commented Nov 2, 2023 •
edited
Loading

There is an issue when, if you try to upload a file (like import in the address book) the pages refreshes and the URL has a new parameter that idk where it comes from. This doesn't happen in prod

Navigate to the Address book Click on import Click on the "choose a file" link to open the file explorer.

RC2

Let's report it as a separate UI issue and fix later. Looks like Windows specific problem.

@liliya-soroka
Copy link
Member

liliya-soroka commented Nov 2, 2023 •
edited
Loading

I connected with Opensea and the tab in the browser got in a state were the icon flickers constantly. The connection was done, no other messages should be pending of signing, so there should be no reason for the icon to flicker like that.

I tried in prod and didn't happened there.

Beyond that flickr, no further issues seem to be regarding connecting to a Dapp RC1

EDIT: I got the same issue duing a swap in the "Swap" Dapp as well

we were not able to reproduce it and find the problem in the code. Let's try to find the steps and report it as a new issue out of the RC

@katspaugh
Fix: WalletConnect - track only tx and signature requests (#2732)
054b53b 
* Fix: WalletConnect - track only tx and signature requests

* Rm href=# from address book upload
@katspaugh
Copy link
Member Author

I've removed the #-href from the upload link in the Address book, so hopefully it's fixed.

@katspaugh katspaugh merged commit 054b53b into main Nov 2, 2023
12 checks passed
@katspaugh katspaugh deleted the release/1.21.0 branch November 2, 2023 10:44
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Safe{Wallet}
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@katspaugh @francovenica @liliya-soroka @mike10ca