-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: soften fallback handler warning #2716
Conversation
Branch preview✅ Deploy successful! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the CowSwap TWAP fallback handler is also static we could allowlist it's address instead. If it is a completely unknown fallback handler I would prefer a warning.
What do you think?
@schmanu allowlist where? |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Coverage report
Show files with reduced coverage 🔻
Test suite run success1044 tests passing in 142 suites. Report generated by 🧪jest coverage report action from 507a1c0 |
For now we could have a list in our repo of known fallback handler addresses where we add the CoW Extensible Fallback Handler addresses I'm just thinking in general having an unexpected / inofficial fallbackhandler hints at a potentially risky setup. Or do we know many other dApps / protocols that use custom fallback handlers? |
If you're implying hardcoding it, I wouldn't do it. |
Verified |
What it solves
The original custom fallback handler warning was added in #1781.
We got feedback from CowSwap that the current warning is too scary to the users when they enable a custom handler for TWAP orders. So we're changing the icon and message to be less alerting.
Official:
Custom:
Unset: