Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: rm redirect from root to last safe #2715

Closed
wants to merge 4 commits into from
Closed

Fix: rm redirect from root to last safe #2715

wants to merge 4 commits into from

Conversation

katspaugh
Copy link
Member

The index page should now always redirect to the Welcome page as the starting page of the app.

@katspaugh katspaugh requested a review from usame-algan October 31, 2023 11:52
@github-actions
Copy link

github-actions bot commented Oct 31, 2023

Branch preview

✅ Deploy successful!

https://last_safe--walletweb.review-wallet-web.5afe.dev

src/pages/index.tsx Outdated Show resolved Hide resolved
usame-algan
usame-algan previously approved these changes Oct 31, 2023
Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change but wasn't it already working like this "by accident" since the last release?

@katspaugh
Copy link
Member Author

@usame-algan it was sometimes redirecting, sometimes not.

Copy link

github-actions bot commented Oct 31, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Oct 31, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 75.18% 9462/12586
🔴 Branches 49.48% 1935/3911
🔴 Functions 57.92% 1423/2457
🟡 Lines 76.85% 8567/11147

Test suite run success

1046 tests passing in 143 suites.

Report generated by 🧪jest coverage report action from 46eac76

@katspaugh
Copy link
Member Author

Let's put this on hold for now.

@katspaugh katspaugh closed this Nov 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2023
@katspaugh katspaugh deleted the last-safe branch December 13, 2023 08:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants