Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Fix Cypress tests #2706

Merged
merged 7 commits into from
Nov 1, 2023
Merged

Tests: Fix Cypress tests #2706

merged 7 commits into from
Nov 1, 2023

Conversation

mike10ca
Copy link
Contributor

What it solves

Resolves #2705

How this PR fixes it

Update test data/logic

@github-actions
Copy link

github-actions bot commented Oct 30, 2023

Branch preview

✅ Deploy successful!

https://fix_cypress_tests--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Oct 30, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

github-actions bot commented Oct 30, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 75.27% 9404/12494
🔴 Branches 49.47% 1923/3887
🔴 Functions 58.2% 1420/2440
🟡 Lines 76.9% 8511/11067

Test suite run success

1044 tests passing in 142 suites.

Report generated by 🧪jest coverage report action from c770c07

@mike10ca mike10ca marked this pull request as ready for review October 31, 2023 15:52
})

it('Verify Tooltip displays correct message for disconnected user [C56019]', () => {
it.only('Verify Tooltip displays correct message for disconnected user [C56019]', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should remove this 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing this

@mike10ca mike10ca requested a review from katspaugh October 31, 2023 19:51
Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@mike10ca mike10ca merged commit fd3ba32 into dev Nov 1, 2023
9 checks passed
@mike10ca mike10ca deleted the fix-cypress-tests branch November 1, 2023 07:01
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Cypress tests
2 participants