-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Seedless Onboarding] Add alternative welcome page #2704
Conversation
Branch preview✅ Deploy successful! |
c7655a4
to
fe12e2c
Compare
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1005 tests passing in 144 suites. Report generated by 🧪jest coverage report action from 77e7d6b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
src/config/routes.ts
Outdated
@@ -1,6 +1,7 @@ | |||
export const AppRoutes = { | |||
'404': '/404', | |||
welcome: '/welcome', | |||
welcomeLp: '/welcome-lp', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/welcome/social-login perhaps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would require us to move the welcome page into a directory and rename all occurences of AppRoutes.welcome
to AppRoutes.welcome.index
though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm aware.
What it solves
Part of #2452
How this PR fixes it
/welcome-lp
according to FigmaHow to test it
/welcome-lp
and observe the pageScreenshots
Checklist