Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Safe creation e2e test for seedless onboarding #2694

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

usame-algan
Copy link
Member

What it solves

With seedless onboarding, the safe creation flow slightly changes so we need to adjust the e2e test for it.

Part of #2542

@usame-algan usame-algan requested a review from schmanu October 26, 2023 12:05
@github-actions
Copy link

github-actions bot commented Oct 26, 2023

Branch preview

✅ Deploy successful!

https://fix_safe_create_e2e--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Oct 26, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

github-actions bot commented Oct 26, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
74.61% (+0.04% 🔼)
9459/12678
🔴 Branches
48.73% (+0.09% 🔼)
1896/3891
🔴 Functions
56.48% (+0.01% 🔼)
1381/2445
🟡 Lines
76.14% (+0.05% 🔼)
8550/11230
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / abTesting.ts
75% (-25% 🔻)
100%
66.67% (-33.33% 🔻)
83.33% (-16.67% 🔻)
🟢
... / useAbTesting.ts
93.75% (-6.25% 🔻)
75% (-25% 🔻)
100%
92.86% (-7.14% 🔻)

Test suite run success

1007 tests passing in 143 suites.

Report generated by 🧪jest coverage report action from 6ee7cd8

@usame-algan usame-algan merged commit 672523f into web3authcoresdk Oct 27, 2023
7 of 8 checks passed
@usame-algan usame-algan deleted the fix-safe-create-e2e branch October 27, 2023 07:20
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants