chore: mock data builder for tests #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! https://poc_chain_builder--walletweb.review-wallet-web.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Coverage report
Show new covered files 🐣
Test suite run success961 tests passing in 133 suites. Report generated by 🧪jest coverage report action from 5a671c8 |
katspaugh
reviewed
Oct 20, 2023
src/tests/builders/chains.ts
Outdated
Comment on lines
29
to
31
| .with('address', faker.finance.ethereumAddress()) | ||
| .with('txHash', faker.string.hexadecimal()) | ||
| .with('api', faker.internet.url({ appendSlash: false })) |
There was a problem hiding this comment.
This with is extremely boilerplaity. Why can't it just be an object?
There was a problem hiding this comment.
It can. I've changed it to accept Partial<T> instead.
katspaugh
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves brittle tests
How this PR fixes it
A new
Builderclass has been added that facilitates mock data generation for tests. An examplechainBuilderhas been created and used in a few demonstrative tests whereuseCurrentChainis mocked.How to test it
Observe the tests passing.
Checklist