[Seedless Onboarding] Adjust Account center design #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! https://account_center_mfa--walletweb.review-wallet-web.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Coverage report
Show new covered files 🐣
Test suite run success1007 tests passing in 143 suites. Report generated by 🧪jest coverage report action from 6b59e1c |
…nter-mfa # Conflicts: # src/components/common/ConnectWallet/AccountCenter.tsx
usame-algan
commented
Oct 23, 2023
|
|
||
| export const UNKNOWN_CHAIN_NAME = 'Unknown' | ||
|
|
||
| const WalletOverview = ({ wallet }: { wallet: ConnectedWallet }): ReactElement => { |
There was a problem hiding this comment.
This is just what WalletInfo was before. Didn't touch any of the code in this file and its styles.
schmanu
approved these changes
Oct 24, 2023
| }) | ||
|
|
||
| await waitFor(() => { | ||
| expect(disconnectButton).not.toBeInTheDocument() |
There was a problem hiding this comment.
We should also expect that the onboard disconnectWallet mock gets called here.
usame-algan
force-pushed
the
account-center-mfa
branch
from
28668a4 to
21ce7d2
Compare
usame-algan
force-pushed
the
account-center-mfa
branch
from
9c232bb to
6b59e1c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Part of #2452
How this PR fixes it
WalletInfotoWalletOverviewAccountCenterinto a new component calledWalletInfofor better testabilityToDos
How to test it
Screenshots
Checklist