-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: track safeAddress on Safe creation #2648
Conversation
Branch preview✅ Deploy successful! https://safe_creation_event--walletweb.review-wallet-web.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Coverage report
Test suite run success961 tests passing in 133 suites. Report generated by 🧪jest coverage report action from 659a0c7 |
8df6387
to
113b60e
Compare
Safe address is sent in a separate custom dimension for all events. A label is no bueno. It's usually taken from the URL but you can add the option to take it from a pending Safe creation. |
ae61073
to
bf16b73
Compare
bf16b73
to
659a0c7
Compare
What it solves
Adds safeAddress to safe creation event
How to test it