Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: track safeAddress on Safe creation #2648

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Oct 18, 2023

What it solves

Adds safeAddress to safe creation event

How to test it

  1. Create a new safe
  2. Observe that the safe address exists in GTM on the Created Safe event
  3. Navigate to that safe
  4. Observe that the safe address is still there

@usame-algan usame-algan requested a review from katspaugh October 18, 2023 08:43
@github-actions
Copy link

github-actions bot commented Oct 18, 2023

Branch preview

✅ Deploy successful!

https://safe_creation_event--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Oct 18, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

github-actions bot commented Oct 18, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
74.86% (+0.02% 🔼)
8966/11977
🔴 Branches
48.72% (+0.03% 🔼)
1808/3711
🔴 Functions
57% (+0.04% 🔼)
1323/2321
🟡 Lines
76.44% (+0.01% 🔼)
8102/10599

Test suite run success

961 tests passing in 133 suites.

Report generated by 🧪jest coverage report action from 659a0c7

@katspaugh
Copy link
Member

katspaugh commented Oct 18, 2023

Safe address is sent in a separate custom dimension for all events. A label is no bueno. It's usually taken from the URL but you can add the option to take it from a pending Safe creation.

@usame-algan usame-algan force-pushed the safe-creation-event branch 2 times, most recently from ae61073 to bf16b73 Compare October 18, 2023 10:33
@usame-algan usame-algan changed the title fix: Adjust safe creation event to include safeAddress fix: Include safeAddress metric sooner Oct 18, 2023
@katspaugh katspaugh changed the title fix: Include safeAddress metric sooner fix: track safeAddress on Safe creation Oct 18, 2023
@francovenica
Copy link
Contributor

Looks good.
The safeAddress value is set in the tracker after the safe is successfully created.
Visiting the safe dashbard and other areas are being tracked normally

A comparison between current Dev and this PR to see the change:
image
image

@usame-algan usame-algan merged commit 584eed7 into dev Oct 26, 2023
9 checks passed
@usame-algan usame-algan deleted the safe-creation-event branch October 26, 2023 15:08
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants