fix: clear pairing URI on rejection #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview⏳ Deploying a preview site... |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
katspaugh
reviewed
Oct 17, 2023
| @@ -66,7 +62,7 @@ const WcInput = ({ uri }: { uri: string }): ReactElement => { | |||
| label={error ? error.message : 'Pairing UI'} | |||
| placeholder="wc:" | |||
| InputProps={{ | |||
| endAdornment: isFirefox ? undefined : ( | |||
| endAdornment: isFirefox() ? undefined : ( | |||
There was a problem hiding this comment.
Suggested change
| endAdornment: isFirefox() ? undefined : ( | |
| endAdornment: isPastingSupported() ? undefined : ( |
katspaugh
approved these changes
Oct 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves stale pairing URIs in input
How this PR fixes it
When rejecting a session proposal, the pairing URI is cleared from the URL/clipboard (state) meaning that the input is not populated with the value.
How to test it
Copy a pairing URI from a DApp and reject the proposal, observing no value prepopulating the input field.
Screenshots
Checklist