fix: WC session list height #2642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! https://wc_session_height--walletweb.review-wallet-web.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
katspaugh
approved these changes
Oct 17, 2023
katspaugh
reviewed
Oct 17, 2023
| @@ -9,7 +9,7 @@ | |||
| .sessionListItem { | |||
| border: 1px solid var(--color-border-light); | |||
| border-radius: 6px; | |||
| height: 56px; | |||
| min-height: 56px; | |||
There was a problem hiding this comment.
Setting a pixel height of anything is per se an anti-pattern. Why can't it just be the size of the content?
There was a problem hiding this comment.
It's to match the height of the input field/our "global" Accordion min-height:
vs.
Shall I remove it?
|
can be merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves overflow of DApp names
How this PR fixes it
The
ListItems ofSessionListnow have amin-heightinstead of fixedheight.How to test it
Connect to CoW Swap via WC and observe no overflow of the name.
Screenshots
Checklist