fix: session management when switching chains #2640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview⏳ Deploying a preview site... |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
katspaugh
reviewed
Oct 17, 2023
| useEffect(() => { | ||
| if (!walletConnect || isSafeConnected) return | ||
|
|
||
| walletConnect.disconnectAllSessions().catch(setError) |
There was a problem hiding this comment.
What if a Safe is just being loaded? WC sessions live across page reloads unless disconnected.
Or the user went to the Welcome page temporarily.
I wouldn't disconnect anything per se, I would just stop accepting requests for a given Safe if you're in another Safe/outside of any Safe.
There was a problem hiding this comment.
We reference the safe search param for this reason.
katspaugh
reviewed
Oct 17, 2023
src/services/walletconnect/utils.ts
Outdated
| }, | ||
| }, | ||
| }) | ||
| } |
There was a problem hiding this comment.
Stylistically, I don't see this function as a util. I would keep it as a private method in the WalletConnectWallet class.
katspaugh
approved these changes
Oct 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves unsupported sessions remaining connected
How this PR fixes it
How to test it
Screenshots
Checklist