Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Seedless Onboarding] Account center redesign #2607

Merged
merged 7 commits into from
Oct 11, 2023

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Oct 10, 2023

What it solves

Resolves #2589

How this PR fixes it

  • Adds a new component SocialLoginInfo that is similar to EthHashInfo
  • Refactors useConnectWallet

How to test it

  1. Open the app
  2. Press Connect Wallet
  3. Observe the new design
  4. Connect a MM wallet
  5. Observe the new design
  6. Connect via Social Login
  7. Observe the new design
  8. The copy button should copy the address
  9. The explorer button should open the address in the block explorer

Screenshots

Screenshot 2023-10-10 at 12 30 44 Screenshot 2023-10-10 at 12 32 44 Screenshot 2023-10-10 at 12 33 01 Screenshot 2023-10-10 at 16 36 20

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@usame-algan usame-algan requested a review from schmanu October 10, 2023 10:33
@github-actions
Copy link

github-actions bot commented Oct 10, 2023

Branch preview

✅ Deploy successful!

https://account_center--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Oct 10, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good.

I found one weird issue but could not find out what change is causing this. But I cannot reproduce it on the epic branch:
When opening the account center, network selector or any other of the modals from the header, the header moves by ~8px.

Screen.Recording.2023-10-10.at.17.56.28.mov

@@ -3,7 +3,8 @@ import * as file from '../pages/import_export.pages'
import * as main from '../pages/main.page'
import * as constants from '../../support/constants'

describe('Import Export Data', () => {
// TODO: This is currently removed from the welcome page
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we not use the global settings -> data page instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, lets move it there! cc @mike10ca

@usame-algan
Copy link
Member Author

When opening the account center, network selector or any other of the modals from the header, the header moves by ~8px.

If I understand correctly this is related to the modals removing scroll when they open. This is the default behavior of MUI popups afaik.

@usame-algan usame-algan requested a review from schmanu October 11, 2023 07:11
@usame-algan usame-algan merged commit cc7398b into web3authcoresdk Oct 11, 2023
7 checks passed
@usame-algan usame-algan deleted the account-center branch October 11, 2023 08:04
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants