-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Seedless Onboarding] Account center redesign #2607
Conversation
Branch preview✅ Deploy successful! https://account_center--walletweb.review-wallet-web.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
f38685a
to
499a656
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good.
I found one weird issue but could not find out what change is causing this. But I cannot reproduce it on the epic branch:
When opening the account center, network selector or any other of the modals from the header, the header moves by ~8px.
Screen.Recording.2023-10-10.at.17.56.28.mov
@@ -3,7 +3,8 @@ import * as file from '../pages/import_export.pages' | |||
import * as main from '../pages/main.page' | |||
import * as constants from '../../support/constants' | |||
|
|||
describe('Import Export Data', () => { | |||
// TODO: This is currently removed from the welcome page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we not use the global settings -> data page instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, lets move it there! cc @mike10ca
If I understand correctly this is related to the modals removing scroll when they open. This is the default behavior of MUI popups afaik. |
What it solves
Resolves #2589
How this PR fixes it
SocialLoginInfo
that is similar toEthHashInfo
useConnectWallet
How to test it
Screenshots
Checklist